-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Community Page #153
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mahfuza <[email protected]>
Signed-off-by: Mahfuza <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the "Improve Community Page" Pull Request brings several positive changes to the community section. It adds instructions for signing commits, a reminder to ensure CI passes, and a section about the Code of Conduct. The changes promote a positive and inclusive environment. There are a few potential issues and errors that need to be addressed. These include a minor typo in the commit message, a mismatch between the language of the patch and the file being modified, a lack of explanation for the changes made, the need to verify the URIs used, and the need for more elaboration on the purpose of signing off commits. The key findings from the overall summary include the positive impact of the changes on the community section, the need to address potential issues and errors, and the importance of providing more context and elaboration for certain changes. DetailsCommit 5a6add96d8f8a181cb8e107879b92e18715265a0Key changes:
Potential problems:
Overall, these changes improve the community section by providing additional guidelines for contributors and promoting a positive and inclusive environment through the inclusion of the Code of Conduct. Commit 759e0bde7e1df8b454c1cdf73d7746a97cedb09aKey changes in the patch:
Potential problems:
Overall, the changes in the patch appear to improve the community page by adding important information and reminders. However, some minor issues and potential problems need to be addressed before merging the pull request. Commit 0aa7cd617322a44bf7bdd3754fdb6221a2c09a03Key Changes:
Potential Problems:
Overall, the changes seem reasonable and do not introduce any major issues. Commit 10aac517d88e82bcac81ee2f26fff02a43fbf960Key Changes:
Potential Problems:
Overall, the patch adds a new section to the contribute.md file, providing information about the WasmEdge ecosystem. The changes appear to be well-implemented and there are no potential problems identified. Commit 265bcafe5567dc1b8950b8f859bf88bd40739e5dKey changes:
Potential problems:
Commit c1713ee1558408c01e153a80a8cbbabaa2ef9d5dKey changes:
Potential problems:
Additional suggestions:
Commit e157778fc599b9a35fb0f2e7a07e0af9a3f8e3f2Key changes in this patch include:
Potential problems:
|
Signed-off-by: Mahfuza <[email protected]>
Signed-off-by: Mahfuza <[email protected]>
…into community
Signed-off-by: Mahfuza <[email protected]>
Hi @mhmohona Please check out my comments. Thanks. |
Hi @mhmohona Did you have any updates on this project? |
Signed-off-by: Mahfuza <[email protected]>
Signed-off-by: Mahfuza <[email protected]>
|
||
- **Plugins**: These are extensions of WASM host functions along with their dependencies. They extend the functionality of the WasmEdge runtime. | ||
|
||
- **Tools**: These are runtime executables. For instance, WasmEdge-TensorFlow-Tools are released tools to execute WASM with access to TensorFlow or TensorFlow-Lite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@q82419 Could you please confirm if the message here is out of date? I remember that tensorflow also is a plugin. Thanks.
Hi @mhmohona You didn't reply to my last comment. Please take a look. Thanks. |
Hey @alabulei1, wasnt the question asked to @q82419? |
Explanation
Improved the Push and Create A Pull Request section.
Added Code of Conduct section.
Added Understanding the WasmEdge Ecosystem section
Related issue
What type of PR is this
Proposed Changes