Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling resetPingTimeout on each ping #5537

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

paranormal
Copy link
Contributor

Creating a release? Please use the Release PR Template instead.

Description

We built a web wallet app and noticed an unusually high number of relayer disconnected messages in logs. The relayer was not resetting the ping timeout on every ping, just on the first one. This MR fixes this. Also, I've noticed that increasing the wait interval to an additional 4 seconds made the error disappear completely.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

After the fix, I see only Disconnecting for load balancing reasons disconnects in server logs.

Fixes/Resolves (Optional)

Examples/Screenshots (Optional)

Use this table template to show examples of your changes:

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@bkrem bkrem requested a review from ganchoradkov December 11, 2024 15:21
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! Please re-add the missing const as its breaking the build

packages/core/src/controllers/relayer.ts Outdated Show resolved Hide resolved
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ganchoradkov ganchoradkov merged commit d80b097 into WalletConnect:v2.0 Dec 12, 2024
4 of 9 checks passed
@ganchoradkov ganchoradkov mentioned this pull request Dec 13, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants