feat: Notifications History with changed ids #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elyniss
requested review from
kacperoak,
jakubuid,
Talhaali00 and
a team
as code owners
Qodana Community for Android57 new problems were found
View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
jakubuid
reviewed
Jan 29, 2024
protocol/notify/src/main/kotlin/com/walletconnect/notify/client/NotifyProtocol.kt
Outdated
Show resolved
Hide resolved
jakubuid
reviewed
Jan 29, 2024
protocol/notify/src/main/kotlin/com/walletconnect/notify/common/model/EngineMapper.kt
Show resolved
Hide resolved
jakubuid
reviewed
Jan 29, 2024
protocol/notify/src/main/kotlin/com/walletconnect/notify/engine/NotifyEngine.kt
Show resolved
Hide resolved
jakubuid
reviewed
Jan 29, 2024
|
|
||
| onNotifyDeleteResponseUseCase.events | ||
| onDeleteResponseUseCase.events | ||
| .filter { it.first == params } | ||
| .map { it.second } |
There was a problem hiding this comment.
Can't .filter and .map be included in onDeleteResponseUseCase?
There was a problem hiding this comment.
No because they need to match request params. They could be other delete responses happening at time of collecting
jakubuid
reviewed
Jan 29, 2024
...otify/src/main/kotlin/com/walletconnect/notify/engine/calls/GetNotificationHistoryUseCase.kt
Outdated
Show resolved
Hide resolved
jakubuid
reviewed
Jan 29, 2024
...otify/src/main/kotlin/com/walletconnect/notify/engine/calls/GetNotificationHistoryUseCase.kt
Show resolved
Hide resolved
jakubuid
reviewed
Jan 29, 2024
protocol/notify/src/main/kotlin/com/walletconnect/notify/engine/domain/FetchDidJwtInteractor.kt
Outdated
Show resolved
Hide resolved
jakubuid
reviewed
Jan 29, 2024
...n/kotlin/com/walletconnect/sample/wallet/ui/routes/composable_routes/inbox/InboxViewModel.kt
Outdated
Show resolved
Hide resolved
kacperoak
reviewed
Jan 29, 2024
...c/main/kotlin/com/walletconnect/notify/engine/responses/OnGetNotificationsResponseUseCase.kt
Outdated
Show resolved
Hide resolved
...letconnect/sample/wallet/ui/routes/composable_routes/notifications/NotificationsViewModel.kt
Show resolved
Hide resolved
...tify/src/main/kotlin/com/walletconnect/notify/engine/responses/OnSubscribeResponseUseCase.kt
Show resolved
Hide resolved
kacperoak
approved these changes
Jan 29, 2024
jakubuid
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.