Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W3M] Downgrade accompanist / navigation version #1277

Merged
merged 10 commits into from
Jan 24, 2024

Conversation

kacperoak
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jan 11, 2024

Qodana Community for Android

98 new problems were found

Inspection name Severity Problems
Use TOML Version Catalog Instead 🔶 Warning 48
Unstable API Usage 🔶 Warning 26
Serializable object must implement 'readResolve' 🔶 Warning 10
Constant conditions 🔶 Warning 10
Control flow with empty body 🔶 Warning 1
JUnit malformed declaration 🔶 Warning 1
Argument could be converted to 'Set' to improve performance ◽️ Notice 1
Constant conditions ◽️ Notice 1
View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

…nV2 into fix/w3m/downgrade_accompanis_okx

# Conflicts:
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/Web3ModalSheet.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/components/internal/Web3ModalComponent.kt
@kacperoak kacperoak marked this pull request as ready for review January 19, 2024 15:30
@kacperoak kacperoak requested review from Elyniss, jakubuid, Talhaali00 and a team as code owners January 19, 2024 15:30
@kacperoak kacperoak merged commit 08cad57 into develop Jan 24, 2024
15 checks passed
@kacperoak kacperoak deleted the fix/w3m/downgrade_accompanis_okx branch January 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants