Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W3M] Add coinbase integration #1273

Merged
merged 20 commits into from
Jan 25, 2024
Merged

[W3M] Add coinbase integration #1273

merged 20 commits into from
Jan 25, 2024

Conversation

kacperoak
Copy link
Contributor

PR includes:

  • coinbase integration
  • session refactor (changed models)
  • move logic from Web3Modal to Web3Modal engine

@kacperoak
add coinbase dependency
084dd40
@kacperoak
Add Coinbase Client
92a1ddc
@kacperoak
Merge branch 'develop' of github.com:WalletConnect/WalletConnectKotli…
f8899e7 
…nV2 into feature/w3m/coinbase_sdk
@kacperoak
Add sealed session model
6d3b653
@kacperoak
Refactor session and make coinbase working
ec4340e
@kacperoak
Merge branch 'develop' of github.com:WalletConnect/WalletConnectKotli…
bfcaea1 
…nV2 into feature/w3m/coinbase_sdk

# Conflicts:
#	product/web3modal/build.gradle.kts
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/routes/account/AccountViewModel.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/routes/connect/ConnectViewModel.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/routes/connect/WalletDataSource.kt
@kacperoak
Resolve conflicts
a201edb
@kacperoak
fix build
e762e28
@kacperoak
Move request models to another package files
746346b
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

Qodana Community for Android

98 new problems were found

Inspection name Severity Problems
Use TOML Version Catalog Instead 🔶 Warning 48
Unstable API Usage 🔶 Warning 26
Serializable object must implement 'readResolve' 🔶 Warning 10
Constant conditions 🔶 Warning 10
Control flow with empty body 🔶 Warning 1
JUnit malformed declaration 🔶 Warning 1
Argument could be converted to 'Set' to improve performance ◽️ Notice 1
Constant conditions ◽️ Notice 1
View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@kacperoak kacperoak marked this pull request as ready for review January 9, 2024 09:25
@kacperoak kacperoak requested review from Elyniss, jakubuid, Talhaali00 and a team as code owners January 9, 2024 09:25
Talhaali00
Talhaali00 reviewed Jan 10, 2024
View reviewed changes
product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/client/Web3Modal.kt Show resolved Hide resolved
...odal/src/main/kotlin/com/walletconnect/web3/modal/client/models/request/SentRequestResult.kt Show resolved Hide resolved
product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/di/EngineModule.kt Outdated Show resolved Hide resolved
product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/di/Web3ModalDITags.kt Outdated Show resolved Hide resolved
product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/domain/SessionRepository.kt Outdated Show resolved Hide resolved
...uct/web3modal/src/main/kotlin/com/walletconnect/web3/modal/engine/coinbase/CoinbaseResult.kt Outdated Show resolved Hide resolved
product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/engine/Web3ModalEngine.kt Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

Qodana Community for Android

98 new problems were found

Inspection name Severity Problems
Use TOML Version Catalog Instead 🔶 Warning 48
Unstable API Usage 🔶 Warning 26
Serializable object must implement 'readResolve' 🔶 Warning 10
Constant conditions 🔶 Warning 10
Control flow with empty body 🔶 Warning 1
JUnit malformed declaration 🔶 Warning 1
Argument could be converted to 'Set' to improve performance ◽️ Notice 1
Constant conditions ◽️ Notice 1
View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@kacperoak
Coinbase connection check
3be1409
@kacperoak
Format code
9c68aeb
@kacperoak
Merge branch 'develop' of github.com:WalletConnect/WalletConnectKotli…
a2343f6 
…nV2 into feature/w3m/coinbase_sdk

# Conflicts:
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/client/Web3Modal.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/domain/SessionRepository.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/domain/usecase/GetSessionUseCase.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/Web3ModalViewModel.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/components/internal/Web3ModalComponent.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/routes/account/AccountViewModel.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/routes/connect/ParingController.kt
#	product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/routes/connect/WalletDataSource.kt
#	sample/modal/src/main/kotlin/com/walletconnect/sample/modal/ModalSampleDelegate.kt
@kacperoak
Merge and fixes after conflicts
1f532a3
@kacperoak kacperoak merged commit 31105b9 into develop Jan 25, 2024
15 checks passed
@kacperoak kacperoak deleted the feature/w3m/coinbase_sdk branch January 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubuid jakubuid jakubuid approved these changes

@Talhaali00 Talhaali00 Talhaali00 approved these changes

@Elyniss Elyniss Awaiting requested review from Elyniss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kacperoak @Talhaali00 @jakubuid