New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAIP-222/ReCaps #1272

Merged

jakubuid merged 28 commits into sign_2.5 from sign_2.5_recaps

Feb 2, 2024

Merged

CAIP-222/ReCaps #1272

Send session request over authenticated session flow

GitHub Actions / Qodana Community for Android completed Jan 5, 2024 in 0s

42 new problems found by Qodana Community for Android

Community for Android

42 new problems were found

Inspection name	Severity	Problems
`Constant conditions`	🔶 Warning	26
`Serializable object must implement 'readResolve'`	🔶 Warning	10
`Control flow with empty body`	🔶 Warning	1
`JUnit malformed declaration`	🔶 Warning	1
`Constant conditions`	◽️ Notice	3
`Argument could be converted to 'Set' to improve performance`	◽️ Notice	1

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 37 in sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/ui/Web3WalletActivity.kt

github-actions / Qodana Community for Android

Control flow with empty body

'if' has empty body

Check notice on line 105 in sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/NotificationHandler.kt

github-actions / Qodana Community for Android

Argument could be converted to 'Set' to improve performance

The argument can be converted to 'Set' to improve performance

Check warning on line 16 in core/android/src/test/java/CacaoTestJvmTest.java

github-actions / Qodana Community for Android

JUnit malformed declaration

Test class `CacaoTestJvmTest` is not constructable because it is not 'public'

Check warning on line 17 in protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 7 in protocol/auth/src/main/kotlin/com/walletconnect/auth/common/exceptions/Exceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 18 in protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 11 in protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 20 in protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 19 in protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 10 in protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 15 in protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 8 in protocol/auth/src/main/kotlin/com/walletconnect/auth/common/exceptions/Exceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 5 in product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/domain/model/Exceptions.kt

github-actions / Qodana Community for Android

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve'

Check warning on line 63 in core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/rpc/JsonRpcHistory.kt

github-actions / Qodana Community for Android

Constant conditions

Condition 'record.response == null' is always false when reached

Check warning on line 28 in product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/navigation/account/Navigation.kt

github-actions / Qodana Community for Android

Constant conditions

Condition 'it.id == chainId' is always false

Check warning on line 21 in sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/EthAccountDelegate.kt

github-actions / Qodana Community for Android

Constant conditions

Condition 'sharedPreferences.getString(ACCOUNT_TAG, null) != null' is always true

Check warning on line 39 in protocol/sign/src/main/kotlin/com/walletconnect/sign/storage/sequence/SessionStorageRepository.kt

github-actions / Qodana Community for Android

Constant conditions

Condition 'hasTopic' is always true

Check warning on line 54 in core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/rpc/JsonRpcHistory.kt

github-actions / Qodana Community for Android

Constant conditions

Condition 'record.response == null' is always false

Check warning on line 178 in sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/ui/routes/composable_routes/inbox/discover/DiscoverTab.kt

github-actions / Qodana Community for Android

Constant conditions

Condition 'parsedUrl != null' is always true

Check warning on line 28 in sample/common/src/main/kotlin/com/walletconnect/sample/common/ui/ComposeExtensions.kt

github-actions / Qodana Community for Android

Constant conditions

'when' branch is never reachable

Check warning on line 76 in core/android/src/main/kotlin/com/walletconnect/android/internal/common/signing/eip1271/EIP1271Verifier.kt

github-actions / Qodana Community for Android

Constant conditions

Cast will always fail

Check warning on line 9 in core/modal/src/main/kotlin/com/walletconnect/modal/utils/DeviceUtils.kt

github-actions / Qodana Community for Android

Constant conditions

Condition 'LocalConfiguration.current.orientation == Configuration.ORIENTATION_LANDSCAPE' is always false

Check warning on line 21 in sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/EthAccountDelegate.kt

github-actions / Qodana Community for Android

Constant conditions

Condition '(sharedPreferences.getString(ACCOUNT_TAG, null) != null) \&\& (sharedPreferences.getString(PRIVATE_KEY_TAG, null) != null) \&\& (sharedPreferences.getString(PUBLIC_KEY_TAG, null) != null)' is always true

Check warning on line 21 in sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/EthAccountDelegate.kt

github-actions / Qodana Community for Android

Constant conditions

Condition '(sharedPreferences.getString(ACCOUNT_TAG, null) != null) \&\& (sharedPreferences.getString(PRIVATE_KEY_TAG, null) != null)' is always true

Check notice on line 114 in core/android/src/main/kotlin/com/walletconnect/android/internal/common/adapter/JsonRpcResultAdapter.kt

github-actions / Qodana Community for Android

Constant conditions

Value of 'jsonrpc' is always null

View more details on GitHub Actions