Add new rejection tags for 1click auth

WalletConnect · Apr 24, 2024 · c532adf · c532adf
1 parent 935cc06
commit c532adf
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/core/android/src/main/kotlin/com/walletconnect/android/internal/common/model/Tags.kt b/core/android/src/main/kotlin/com/walletconnect/android/internal/common/model/Tags.kt
@@ -11,8 +11,8 @@ enum class Tags(val id: Int) {
 
     SESSION_PROPOSE(1100),
     SESSION_PROPOSE_RESPONSE_APPROVE(1101),
-    SESSION_PROPOSE_RESPONSE_REJECT(1118),
-    SESSION_PROPOSE_RESPONSE_AUTO_REJECT(1119),
+    SESSION_PROPOSE_RESPONSE_REJECT(1120),
+    SESSION_PROPOSE_RESPONSE_AUTO_REJECT(1121),
 
     SESSION_SETTLE(1102),
     SESSION_SETTLE_RESPONSE(1103),
@@ -36,7 +36,9 @@ enum class Tags(val id: Int) {
     SESSION_PING_RESPONSE(1115),
 
     SESSION_AUTHENTICATE(1116),
-    SESSION_AUTHENTICATE_RESPONSE(1117),
+    SESSION_AUTHENTICATE_RESPONSE_APPROVE(1117),
+    SESSION_AUTHENTICATE_RESPONSE_REJECT(1118),
+    SESSION_AUTHENTICATE_RESPONSE_AUTO_REJECT(1119),
 
     CHAT_INVITE(2000),
     CHAT_INVITE_RESPONSE(2001),

diff --git a/.../kotlin/com/walletconnect/sign/engine/use_case/calls/ApproveSessionAuthenticateUseCase.kt b/.../kotlin/com/walletconnect/sign/engine/use_case/calls/ApproveSessionAuthenticateUseCase.kt
@@ -87,7 +87,7 @@ internal class ApproveSessionAuthenticateUseCase(
             val symmetricKey: SymmetricKey = crypto.generateSymmetricKeyFromKeyAgreement(senderPublicKey, receiverPublicKey)
             val responseTopic: Topic = crypto.getTopicFromKey(receiverPublicKey)
             val sessionTopic = crypto.getTopicFromKey(symmetricKey)
-            val irnParams = IrnParams(Tags.SESSION_AUTHENTICATE_RESPONSE, Ttl(dayInSeconds))
+            val irnParams = IrnParams(Tags.SESSION_AUTHENTICATE_RESPONSE_APPROVE, Ttl(dayInSeconds))
 
             if (cacaos.find { cacao -> !cacaoVerifier.verify(cacao) } != null) {
                 logger.error("Invalid Cacao for Session Authenticate")

diff --git a/...n/kotlin/com/walletconnect/sign/engine/use_case/calls/RejectSessionAuthenticateUseCase.kt b/...n/kotlin/com/walletconnect/sign/engine/use_case/calls/RejectSessionAuthenticateUseCase.kt
@@ -62,7 +62,7 @@ internal class RejectSessionAuthenticateUseCase(
         val responseTopic: Topic = crypto.getTopicFromKey(receiverPublicKey)
 
         crypto.setKey(symmetricKey, responseTopic.value)
-        val irnParams = IrnParams(Tags.SESSION_AUTHENTICATE_RESPONSE, Ttl(dayInSeconds), false)
+        val irnParams = IrnParams(Tags.SESSION_AUTHENTICATE_RESPONSE_REJECT, Ttl(dayInSeconds), false)
 
         logger.log("Sending Session Authenticate Reject on topic: $responseTopic")
         jsonRpcInteractor.publishJsonRpcResponse(

diff --git a/...in/kotlin/com/walletconnect/sign/engine/use_case/requests/OnSessionAuthenticateUseCase.kt b/...in/kotlin/com/walletconnect/sign/engine/use_case/requests/OnSessionAuthenticateUseCase.kt
@@ -36,7 +36,7 @@ internal class OnSessionAuthenticateUseCase(
     val events: SharedFlow<EngineEvent> = _events.asSharedFlow()
 
     suspend operator fun invoke(request: WCRequest, authenticateSessionParams: SignParams.SessionAuthenticateParams) = supervisorScope {
-        val irnParams = IrnParams(Tags.SESSION_AUTHENTICATE_RESPONSE, Ttl(dayInSeconds))
+        val irnParams = IrnParams(Tags.SESSION_AUTHENTICATE_RESPONSE_AUTO_REJECT, Ttl(dayInSeconds))
         logger.log("Received session authenticate: ${request.topic}")
         try {
             if (Expiry(authenticateSessionParams.expiryTimestamp).isExpired()) {