Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WB-29: Implement Enricher Pattern #110

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

WB-29: Implement Enricher Pattern #110

wants to merge 44 commits into from

Conversation

nnichols
Copy link
Member

@nnichols nnichols commented Oct 7, 2023

Proposed Changes

TODO - This is WIP

  • Additions:
  • Updates:
  • Deletions:

Pre-merge Checklist

  • Write + run tests
  • Update CHANGELOG and increment version
  • Update README and relevant documentation

@nnichols nnichols requested a review from a team as a code owner October 7, 2023 14:42
@WallBrewBot WallBrewBot added documentation Improvements or additions to documentation dotfiles Configuration files for developer tools and CI/CD restricted Files not intended for public revision test code Updates to the application or library test code source code Updates to the application or library source code tooling Repository tools, CI/CD jobs, automated actions labels Oct 7, 2023
WallBrewBot
WallBrewBot reviewed Oct 7, 2023
View reviewed changes
doc/patterns/enricher-pattern.md Show resolved Hide resolved
doc/patterns/enricher-pattern.md Outdated Show resolved Hide resolved
test/brewtility/enrich/equipment_test.cljc Outdated Show resolved Hide resolved
test/brewtility/enrich/equipment_test.cljc Outdated Show resolved Hide resolved
test/brewtility/enrich/equipment_test.cljc Outdated Show resolved Hide resolved
test/brewtility/enrich/equipment_test.cljc Show resolved Hide resolved
test/brewtility/enrich/equipment_test.cljc Show resolved Hide resolved
src/brewtility/enrich/impl.cljc Show resolved Hide resolved
src/brewtility/enrich/impl.cljc Show resolved Hide resolved
src/brewtility/units/volume.cljc Show resolved Hide resolved
@WallBrewBot WallBrewBot added dependencies Updates to application dependency files clojure Clojure source code clojurescript ClojureScript source code labels Feb 19, 2024
nnichols and others added 27 commits March 11, 2024 13:11
@nnichols
Fix linting
61f0688
@nnichols
Enrichers for miscs
f9985be
@nnichols
Add water enrichers
57fdb26
@nnichols
Fix spacing
db1fd67
@nnichols
Add symbolic keys pattern for enrichers
30454bd
@nnichols
Add yeast enrichers
82ec958
@nnichols
Add symbolic keys for units of measure
e2bb3b4
@nnichols
Finish rebasing
404bb77
@nnichols
Fix rebasing errors
a07c4f1
@nnichols
Fix rebasing errors
a6d3850
@nnichols
Fix rebasing errors
d4b23ee
@nnichols
Fix rebasing errors
d9664b0
@nnichols
Fix :added keys
6bdf54a
@nnichols
Finish all base enrichers
da713ce
@nnichols
Test all enricher implementation functions
70564f4
@nnichols
Fix typo in test string
f3edf10
@nnichols
De-dupe enricher implementation
6f6ff41
@nnichols
Fix up linter
8e00e01
@nnichols
WIP
f754859
@nnichols
Clean up test data
1854f17
@nnichols
[Format] Auto-formatting
56bd49d
@nnichols
Begin accumulating changes for sealog
4ab767b
@nnichols
Document bitterness unit
b2d9c27
@nnichols
Add carbonation units
81bbea0
@nnichols
Add tests for new unit systems
96ee281
@nnichols
Add degrees plato
bc0fff6
@nnichols
WIP
7aa178d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WallBrewBot WallBrewBot WallBrewBot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
clojure Clojure source code clojurescript ClojureScript source code dependencies Updates to application dependency files documentation Improvements or additions to documentation dotfiles Configuration files for developer tools and CI/CD restricted Files not intended for public revision source code Updates to the application or library source code test code Updates to the application or library test code tooling Repository tools, CI/CD jobs, automated actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nnichols @WallBrewBot