Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug: Unable to Edit Customer from Edit Form #46

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

RasniNathees
Copy link
Contributor

Description:

This pull request addresses a bug in the customer edit form where users were unable to edit customer details. The issue has been identified and resolved.

Changes:

Fixed the issue preventing customer details from being edited in the form.
Updated the relevant form handling logic to ensure changes are correctly saved.
Added validation to ensure all required fields are properly handled.
Testing:

Tested the form to ensure customer details can now be edited successfully.
Verified that all form fields were correctly populated and saved.
Ensured that no new issues were introduced with this fix.
Please review the changes and let me know if there are any further improvements needed.

Related Issues:

Closes #ISSUE_NUMBER (if applicable)
Thank you!

@WailanTirajoh WailanTirajoh added the bug Something isn't working label Aug 1, 2024
@WailanTirajoh
Copy link
Owner

Hi @RasniNathees thankyou for catching this. I think we can utilize UpdateCustomerRequest for that, somehow im using StoreCustomerRequest on both create and update, haha. But, this code looks good to me.

Copy link
Owner

@WailanTirajoh WailanTirajoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou!

@WailanTirajoh WailanTirajoh merged commit 931781f into WailanTirajoh:main Aug 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants