Skip to content

0.2.0
Compare
Choose a tag to compare
@dingo-d dingo-d released this 18 Jul 07:56
· 13 commits to master since this release
0.2.0
1141d45
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Added

  • New WPThemeReview.Templates.ReservedFileNamePrefix sniff: checks if the template file is using a prefix which would cause WP to interpret it as a specialized template, meant to apply to only one page on the site.
  • New WPThemeReview.Privacy.ShortenedURLs sniff: detects the usage of shortened URLs. Handbook rule.
  • New WPThemeReview.CoreFunctionality.PostsPerPage sniff: adds a warning when a high pagination limit is detected, or if -1 is used in posts_per_page setting while querying posts, due to detrimental effects it has on the query speed.
  • New WPThemeReview.CoreFunctionality.PrefixAllGlobals sniff, which extends the WordPress.NamingConventions.PrefixAllGlobals. The new sniff overloads the prefix check for variables only and will bow out if the file being scanned has a typical theme template file name. For all other files, it will fall through to the WPCS native sniff.
    Notes:
    • The new sniff adds a public $allowed_folders property to whitelist files in specific folders of a theme as template files.
      The ruleset.xml file sets this property to a limited set of folders whitelisted by default.
    • Similar to the WPCS FileNameSniff, this sniff does not currently allow for mimetype sublevel only theme template file names, such as plain.php.
  • Added two new groups to the restricted functions group: editor-blocks and cron-functionality in the WPThemeReview.PluginTerritory.ForbiddenFunctions sniff, which will check against core editor blocks being registered in the themes, and against the usage of cron functions in the theme respectively.
  • The WordPress.PHP.IniSet rule was added to the ruleset to check against themes setting ini configuration during runtime.
  • The WordPress.WP.DeprecatedParameterValues rule was added to the ruleset about usage of deprecated parameter values in WP functions. The sniff will suggest an alternative based on the parameter passed.

Changed

  • Added XSD schema tags and validated the ruleset against schema (PHPCS 3.2+/3.3.2+).
  • Updated the minimum version requirement for the WordPress Coding Standards dependency to version 2.1.0.
  • Updated the suggested dealerdirect/phpcodesniffer-composer-installer version.
  • Updated the WPThemeReview codebase, where relevant, for compatibility with WPCS 2.0+.
  • Ruleset tweaks: limit PHPCompatibility to PHP files
  • Composer tweaks: improve readability of script section
  • Travis: Run the code style related and ruleset checks in separate stages.
  • Travis: Unit tests are now also run against PHP 7.4 (dev)
  • Travis: Test against high/low WPCS versions due to sniffs that are extending the WPCS native sniffs.
  • Travis: Minor tweaks to the Travis script.

Removed

  • Remove encoding from the ruleset. The default encoding as of PHPCS 3.0.0 is utf-8, so we don't actually need to set this.

Fixed

  • Removal of HTML from error message about adding menu pages in WPThemeReview.PluginTerritory.NoAddAdminPages sniff.
  • Minor grammar changes in the ruleset.
Assets 2
Loading