Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Handle twitter oembed fallback with interstitial link #1618

Open
wants to merge 1 commit into
base: arc-themes-release-version-1.25
Choose a base branch
from

Conversation

rmbrntt
Copy link
Contributor

@rmbrntt rmbrntt commented Feb 8, 2023

if Twitter API calls get blocked on 2/9 and html is no longer populated

If you have not filled out the checklist below, the pr is not ready for review.

Description

Information about what you changed for this PR

Jira Ticket

Acceptance Criteria

copy from ticket

Test Steps

  • Add test steps a reviewer must complete to test this PR
  1. Checkout this branch git checkout {branch name}
  2. Run fusion repo with linked blocks npx fusion start -f -l {blocks to link}
  3. {Next ....}

Effect Of Changes

Before

Example: When I clicked the search button, the button turned red.

[include screenshot or gif or link to video, storybook would be awesome]

After

Example: When I clicked the search button, the button turned green.

[include screenshot or gif or link to video, storybook would be awesome]

Dependencies or Side Effects

Examples of dependencies or side effects are:

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

…API calls get blocked on 2/9 and html is no longer populated
@rmbrntt rmbrntt requested a review from a team as a code owner February 8, 2023 14:21
@rmbrntt rmbrntt changed the title WIP: stub out code to handle a fallback interstitial link WIP: Handle twitter oembed fallback with interstitial link Feb 8, 2023
@nschubach
Copy link
Contributor

wip?

@rmbrntt rmbrntt added do not merge Do not merge, wait to merge this ticket until this label is removed. WIP Work in progress. Feel free to give feedback, but no formal review is requested at this time. labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge, wait to merge this ticket until this label is removed. WIP Work in progress. Feel free to give feedback, but no formal review is requested at this time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants