Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixes #6

wants to merge 6 commits into from

Conversation

Canic
Copy link

@Canic Canic commented Jan 27, 2020

Hey,

your plugin is simple and awesome. But we need a small fix.
What i have changed:

  • Sync the Wordpress version from you to this github repo
  • added .editorconfig to make changes easier to match your coding standards (tab indent as example)
  • because some part had still space indent, i changed all to tab indent

Now we most important part:

  • use url_parse because when i added a 301 redirect, and the url was used as example on facebook, it didn't work. (Facebook adds a fbclientid param on the URL). Now only the url path will be parsed and compared

Hope to see the fix soon online on wp!
Keep up the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant