Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1914: php8 compat #1916

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

1914: php8 compat #1916

wants to merge 3 commits into from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jan 31, 2023

Changes

This pull request makes the following changes:

  • adds composer for phpunit
  • adds instructions for running tests in docs/readme.md
  • edits tests to support PHPUnit 9
  • edits tests to support PHPUnit 10
  • fixes issues identified by tests in PHP 7.4 and PHP 8
  • adds phpcs rules for backwards compatibility
  • adds docs for running phpcs
  • runs phpcs
  • remedies PHPCS backwards-compatibility tests
  • changelog.md
  • test with Co-Authors Plus

Why

For #1914

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Has the changelog.md file been updated to reflect the updates in this PR?
  • [ ]

Steps to test this PR:

  1. Run Largo on a PHP 8 environment
  2. See tests/readme.md

Additional information

WP Buddy Client requesting: (if applicable)

  • Contributor has read WP Buddy's GitHub code of conduct
  • Contributor would like to be mentioned in the release notes as: Ben Keith
  • Contributor agrees to the license terms of this repository.

@benlk benlk added the type: tech debt For necessary updates because code is old label Jan 31, 2023
@benlk benlk self-assigned this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tech debt For necessary updates because code is old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant