Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Staff List Widget, [roster] shortcode, and related user meta forms #1763

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jul 19, 2019

Changes

This pull request makes the following changes:

  • Removes the Largo Staff List widget
  • Removes the [roster] shortcode
  • Deprecates two functions used for same

To Do

  • Because the meta boxes used by the Staff List Widget and the [roster] shortcode are also used for bylines, specifically the "job title" meta and the "show_email" meta, we're going to have to figure out how Largo and this plugin interact. Who is responsible for providing the form?
    • I think this might work best if Largo keeps the complete form, but unregisters the plugin's corresponding form functions. The metadata would remain the same across both the theme and the plugin.
    • obsoleted by the fact that the plugin will not exist.
  • Clean out tests for deprecated functions
  • Deprecate functions that are no longer used in Largo

Why

Because we're pulling this functionality out of Largo as part of #1505 and https://github.com/INN/staff

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. On a site with many users, and running trunk:
  2. add the [roster] shortcode to a page
  3. Add the Largo Staff Roster widget to a widget area.
  4. Check out this branch.
  5. View the page that has the [roster] shortcode: the shortcode should be visible
  6. View the widget area containing the Largo Staff Roster widget: it should be gone

@benlk benlk added priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: feature request category: plugin compat Issues relating to plugin compatibility labels Jul 19, 2019
@MirandaEcho
Copy link
Collaborator

@benlk benlk requested a review from joshdarby August 21, 2019 19:46
@benlk
Copy link
Collaborator Author

benlk commented Aug 21, 2019

@joshdarby please look at this PR and the corresponding issue and plugin, and chime in on where the metadata should be saved.

@benlk benlk changed the base branch from master to trunk March 11, 2020 22:29
@benlk benlk marked this pull request as ready for review March 11, 2020 23:09
@benlk benlk added status: needs review and removed category: plugin compat Issues relating to plugin compatibility labels Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: needs review type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants