Remove the Staff List Widget, [roster] shortcode, and related user meta forms #1763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes the following changes:
[roster]
shortcodeTo Do
Because the meta boxes used by the Staff List Widget and the[roster]
shortcode are also used for bylines, specifically the "job title" meta and the "show_email" meta, we're going to have to figure out how Largo and this plugin interact. Who is responsible for providing the form?I think this might work best if Largo keeps the complete form, but unregisters the plugin's corresponding form functions. The metadata would remain the same across both the theme and the plugin.Why
Because we're pulling this functionality out of Largo as part of #1505 and https://github.com/INN/staff
Testing/Questions
Features that this PR affects:
[roster]
shortcodeQuestions that need to be answered before merging:
[ ] do we need to make any updates to https://github.com/INN/staff ?Per the 2020-03-03 planning proposals doc we are cancelling this plugin[ ] does the migration function work?Steps to test this PR:
trunk
:[roster]
shortcode to a page[roster]
shortcode: the shortcode should be visible