Revisit the Taxonomy List widget #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de ability to exclude chosen terms, make the taxonomies option a select instead of a text field, improve docs inside and outside the plugin
…use generic render_term_list instead
…(), improve its registration args when it's disabled. Remove unregister_post_types_taxonomy() and Largo_Term_Icons::register_taxonomy()
…t it needs to test.
… the prominence stuff.
benlk
added
type: bug
type: improvement
priority: normal
|
Filed as a bug PR because of #1173, improvement because of the helpdesk ticket that started this. |
This was referenced Mar 31, 2016
|
is that screenshot current? I'd like to remove all the extra inline docs because I think that's overkill if so |
|
It's not, my bad. That came from the last PR. This is the current amount of docs:
|
| case 'series': | ||
| $this->render_series_list($tax_items, $instance); | ||
| $this->render_series_list( $tax_items, $instance ); | ||
| break; | ||
| case 'category': |
There was a problem hiding this comment.
this seems unnecessary, shouldn't we just use an if/else here to use the one function for series and the other function for everything else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
docs/users/sidebarswidgets.rst
## WhyWidget rewrites: to make this widget simpler and more user-friendly. For HELPDESK-589.
Taxonomy registration rewrite: The old method of registering the post-type and series was to, if the theme option to register the taxonomy was not active, register them with empty labels and various amounts of 'hiddenness' based on the registration args. This was causing the inactive taxonomies to appear in an earlier version of this pull request with default "Tag" labels: #1173. The fix for this was to instead always register those taxonomies, but if they were not enabled in the theme options, to register them with the arguments
public,show_admin_columnandshow_in_nav_menusset tofalse.What else?
This does not include the option to sort by last-updated; WordPress does not provide this option. 😞