Declare PHP 7.4+ support and fix PHP 8.x deprecations - #86
Open
spacedmonkey wants to merge 2 commits into
Open
spacedmonkey wants to merge 2 commits into
spacedmonkey wants to merge 2 commits into
Conversation
Bump the plugin header's Requires PHP from 5.6 to 7.4 to match the existing composer.json constraint, add the missing Requires PHP line to readme.txt/README.md, wire up the already-installed PHPCompatibilityWP ruleset in phpcs (open-ended testVersion, no upper bound), expand the CI matrix to 7.4 through 8.5, and fix two PHP 8.x deprecations (implicitly-nullable typed params, dynamic property creation) while keeping PHP 7.4 compatibility. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
roborourke
approved these changes
Sep 18, 2026
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requires PHPfrom 5.6 to 7.4, matching the existingcomposer.jsonconstraint (">=7.4", no upper bound)Requires PHP: 7.4line tobin/readme.txt, and a parity line toREADME.mdphpcompatibility/phpcompatibility-wpdev dependency in.phpcs.xml.distwith an open-endedtestVersion="7.4-"so future PHP 8.x/9 releases keep being checked automatically8.0-8.3to7.4, 8.0-8.5inc/admin/namespace.phpandinc/types/class-base.php— made nullability explicit (?Client,?WP_Error)inc/class-scopes.php— added the missing$scopesproperty declarationNo other PHP 7.4/8.x compatibility issues were found in the codebase (no PHP-8-only syntax, no removed functions, no missing-polyfill risk).
Test plan
composer installsucceedsvendor/bin/phpcsruns clean (24 files, 0 errors, 0 warnings) including the new PHPCompatibilityWP checks🤖 Generated with Claude Code