Skip to content

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Dec 1, 2025

Changes

  • Convert all remaining components to standalone. These are pages that are used in the site like register, login, edit profile, not the VLE, AT, CM.
  • Change how we bootstrap the application by calling bootstrapApplication(AppComponent) in main.ts. Remove AppModule. Before, we were bootstrapping the application in AppModule.
  • Clean up related files

Test

  • Site pages work as before. Register, login, change password, contact form. VLE/AT/CM are not affected by this PR

@qltysh
Copy link

qltysh bot commented Dec 1, 2025

❌ 9 blocking issues (9 total)

Tool Category Rule Count
qlty Duplication Found 26 lines of similar code in 8 locations (mass = 101) 9

@hirokiterashima hirokiterashima self-assigned this Dec 1, 2025
@hirokiterashima hirokiterashima added this to the Standalone Components milestone Dec 1, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review December 1, 2025 23:23
@qltysh
Copy link

qltysh bot commented Dec 4, 2025

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

…d to import RecaptchaV3Module in the component
… in my units page in curriculum. Removed ColorService and put the logic to get contract color in the TagComponent. There was no need for this to be a service
@hirokiterashima
Copy link
Member Author

@breity, please test again. I fixed these issues that you found:

  • Log in -> curriculum, click on tag filter drop down
  • Register accounts -> student or teacher
  • Contact Us

They were missing providers. I also took this opportunity to remove the ColorService and move the getContractColor logic into TagComponent because that's the only place it's used.

Hopefully that's it, but let me know if you find more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants