Skip to content

Hide browser alert when submitting survey #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

Hide browser alert when submitting survey #2193

wants to merge 39 commits into from

Conversation

hirokiterashima
Copy link
Member

Changes

  • Hide browser alert. We have our own dialog.
  • Note: does not work in Firefox: it still tries to show the unit

Test

  • Submit the survey. It should take you to the completed page.

Aaron-Detre and others added 30 commits May 16, 2025 13:06
@Aaron-Detre
Refactor create run dialog
2feb176
@Aaron-Detre
Add run type selection to create run dialog
9c454c3
@Aaron-Detre
Restrict survey student access to student home
730d254
@Aaron-Detre
Survey runs have access links instead of access codes
2c79ec6
@Aaron-Detre
Fixed survey students restricted from survey bug
1f5d62d
@Aaron-Detre
Workgroup limit reached page
15b48b0
@Aaron-Detre
Log out page shown if logged in when accessing survey
25a33d4
@Aaron-Detre
Unique access links for each period
32126f0
@Aaron-Detre
Submit button
3850b8c
@Aaron-Detre
Don't check isSurvey if preview
42ba92c
@Aaron-Detre
Clean code
fdfea1e
@Aaron-Detre
Write tests
5008e6a
@Aaron-Detre
Merge branch 'develop' into survey-units
ff1084b
@Aaron-Detre
Fix tests
8ca729c
@Aaron-Detre
Merge branch 'survey-units' of https://github.com/WISE-Community/WISE…
02c277b 
…-Client into survey-units
@Aaron-Detre
Merge branch 'develop' into survey-units
36e33cb
@github-actions
Updated messages
25700aa
@Aaron-Detre
Merge branch 'develop' into survey-units
1ed1387
@Aaron-Detre
Merge branch 'survey-units' of https://github.com/WISE-Community/WISE…
c15dfef 
…-Client into survey-units
@Aaron-Detre
Fix more tests
27f3ac0
@Aaron-Detre
Fixed another test
35ea419
@Aaron-Detre
Comment out bad test for now
648a110
@Aaron-Detre
Comment out whole file
2f0a24c
@hirokiterashima
Simplify path to launch survey to /run-survey/code
ba7aac8
@hirokiterashima
Fix tests. xdescribe logoutService tests.
840df7e
@Aaron-Detre
Remove log out page
ab7b209
@Aaron-Detre
Prevent custom periods for surveys
deb1a4a
@Aaron-Detre
Merge branch 'survey-units' of https://github.com/WISE-Community/WISE…
bee69b6 
…-Client into survey-units
@hirokiterashima
Fix test
872c19f
@hirokiterashima
Hide Workgroup membership section in Edit Run Settings when in survey…
7d2e64a 
… mode
@hirokiterashima hirokiterashima self-assigned this Jun 4, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review June 4, 2025 22:49
@hirokiterashima hirokiterashima requested a review from breity June 4, 2025 22:49
Base automatically changed from survey-units to develop June 6, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breity breity Awaiting requested review from breity

Assignees

@hirokiterashima hirokiterashima

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hirokiterashima @Aaron-Detre @breity