Skip to content

refactor(LabelStudentComponent): Clean up code #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 29, 2025
Merged

refactor(LabelStudentComponent): Clean up code #2062

merged 13 commits into from
Jan 29, 2025

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Jan 23, 2025 •
edited
Loading

Changes

  • Move util functions to Label.ts
  • Use HOF to simplify logic
  • Add private/protected modifiers to improve encapsulation
  • Remove unnecessary code

Test

  • Label works as before in student and teacher views

@hirokiterashima hirokiterashima added this to the Tech Debt 16 -> 15 milestone Jan 23, 2025
@hirokiterashima hirokiterashima self-assigned this Jan 23, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review January 29, 2025 17:58
@hirokiterashima hirokiterashima merged commit 43f4f75 into develop Jan 29, 2025
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-LabelStudentComponent-Jan-2025 branch January 29, 2025 17:59
@hirokiterashima
Copy link
Member Author

hirokiterashima commented Feb 3, 2025

🎉 This issue has been resolved in version 5.168.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

None yet

Milestone

Tech Debt 16 -> 15

Development

Successfully merging this pull request may close these issues.

2 participants

@hirokiterashima