Skip to content

feat(Project Authoring): Don't open imported step for editing #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

feat(Project Authoring): Don't open imported step for editing #1415

wants to merge 4 commits into from

Conversation

@hirokiterashima
Copy link
Member

Changes

  • Go to project view after importing one or more steps. (before: open step editing view if there was just one imported step)
  • Move highlightNodesAndScroll() function from ProjectAuthoringComponent.ts to dom.ts

Test

  • Importing one or more steps should take you back to the project authoring view and highlight and scroll to the newly imported step(s).

Closes #1414

@hirokiterashima hirokiterashima self-assigned this Sep 11, 2023
@hirokiterashima
Merge branch 'develop' into issue-1414-do-not-open-newly-imported-ste…
2047d5b 
…p-for-editing
@hirokiterashima
Refactor code: make ChooseImportStepLocation component extend
1a79a16 
ChooseNodeLocationComponent. This necessitated changes to make the
insertAfter() and insertInside() functions returns Promises.

#1414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hirokiterashima hirokiterashima

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(Project Authoring): don't open imported step

1 participant

@hirokiterashima