Skip to content

Conversation

hirokiterashima
Copy link
Member

Changes

  • In TeacherProjectService, move these functions to NodeAdvancedBranchAuthoringComponent, where they're actually being called
    • setTransitionLogicField()
    • setTransition()
    • addBranchPathTakenConstraints()
  • Remove TeacherProjectService.isNodeIdUsed() since it's unused
  • Use nullish coalescence (??) in ProjectService.instantiateDefaults()
  • Add private keyword and function return types in surrounding code

Test

  • Node branch authoring works as before (e.g. creates correct transitions and constraints)
  • Unit loads as before in VLE, CM, AT (to test ProjectService.instantiateDefaults())

Closes #1220

@hirokiterashima hirokiterashima self-assigned this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(TeacherProjectService): Move branch authoring code

1 participant