Remove JWK "alg" field #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
approved these changes
Aug 30, 2023
tniessen
approved these changes
Aug 30, 2023
github-actions bot
added a commit
that referenced
this pull request
Aug 30, 2023
SHA: c9eaaac Reason: push, by twiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
panva
added a commit
to panva/node
that referenced
this pull request
Aug 30, 2023
panva
added a commit
to panva/node
that referenced
this pull request
Aug 30, 2023
panva
added a commit
to panva/node
that referenced
this pull request
Aug 30, 2023
|
cc @javifernandez, @youennf, @angelaizg, @Jarred-Sumner - could you follow up to update the Chromium, WebKit, and Bun implementations? I've opened PRs to update Node, Deno (cc @littledivy), and Workerd (cc @jasnell). This I believe covers all implementations either direct or dependencies. |
littledivy
pushed a commit
to denoland/deno
that referenced
this pull request
Aug 31, 2023
As per WICG/webcrypto-secure-curves#24 this removes the check for Ed25519 JWK `alg` during importKey and removes the `alg` for Ed25519 keys during JWK exportKey.
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 1, 2023
As per WICG/webcrypto-secure-curves#24 PR-URL: #49408 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
UlisesGascon
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 10, 2023
As per WICG/webcrypto-secure-curves#24 PR-URL: #49408 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Oct 4, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
As per WICG/webcrypto-secure-curves#24 PR-URL: nodejs#49408 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
algfield is not required and might change in the future, see https://www.ietf.org/archive/id/draft-jones-jose-fully-specified-algorithms-00.html.Fixes #23, reverts #3 and #4.
Preview | Diff