Add support for Ad-Auction-Result-Nonce header #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qingxinwu PTAL |
qingxinwu
reviewed
Feb 4, 2025
qingxinwu
reviewed
Feb 10, 2025
spec.bs
Outdated
| [=traversable navigable's=] [=traversable navigable/captured ad auction result nonce headers=]. | ||
| 1. Let |seller| be |auctionConfig|'s [=auction config/seller=]. | ||
| 1. If |capturedAuctionNonceHeaders|[|seller|] does not [=map/exist=] or does not | ||
| [=list/contain=] the [=string representation=] of |response|'s |
There was a problem hiding this comment.
are both of these guaranteed to be lowercase somewhere? In code, I saw we lowercased the nonces. We need to do it in the spec as well?
There was a problem hiding this comment.
Done. I had previously assumed that UUIDs were canonically lowercase. It turns out that the case is canonically arbitrary 🤷.
qingxinwu
reviewed
Feb 11, 2025
| @@ -3193,6 +3188,20 @@ a [=list=] of [=interest groups=] |bidIgs|, and a [=reporting context map=] | |||
| 1. Let |response| be the [=server auction response=] which is the result of | |||
| deserializing |auctionConfig|'s [=auction config/server response=] | |||
| with |requestContext| according to [Section 2.3.5 of the Bidding and Auction Services IETF standard](https://privacysandbox.github.io/draft-ietf-bidding-and-auction-services/draft-ietf-bidding-and-auction-services.html#name-parsing-a-response). | |||
| 1. If |response|'s [=server auction response/nonce=] [=map/exists=]: | |||
| 1. Let |capturedAuctionNonceHeaders| be |global|'s [=associated Document's=] [=node navigable's=] | |||
There was a problem hiding this comment.
is nonce always lowercase in the result nonce header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.