Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Various minor fixes #301

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

jeremyroman
Copy link
Collaborator

Fixes #300.

* Fix linking to URL Pattern spec after whatwg/urlpattern#219.
* Fix ambiguous "credentials" link by defaulting it to Fetch.
* Fix RFC 2119 compliance in a note.
Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

1. Otherwise, return null.
1. [=Assert=]: |pattern| is a {{URLPattern}}.
1. Let |pattern| be the result of [=building a URL pattern from an Infra value=] |rawPattern| given |baseURL|. If this step throws, catch the exception and return null.
1. [=Assert=]: |pattern| is a [=URL pattern=].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit redundant

Copy link

@jeremyroman jeremyroman merged commit 84320d4 into WICG:main Feb 29, 2024
2 checks passed
@jeremyroman jeremyroman deleted the editorial-20240228 branch February 29, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken references in Speculation Rules
2 participants