Replace LP2PReceiver.ontransport with LP2PQuicTransportListener #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR writes out the last option mentioned in #32.
LP2PReciever.ontransport
is removed in favor of aLP2PQuicTransportListener
object. This allows a QuicTransport to be created/accepted by both theLP2PReceiver
andLP2PRequest
. It also replaces theEventHandler
with aReadableStream
as mentioned in #30.Do we find this to be an improvement overall? The new code examples look reasonable to me. The downsides I see are:
LP2PQuicTransportListener
is quite long.LP2PQuicTransport
andLP2PQuicTransportListener
constructors in addition toLP2PReceiver
andLP2PRequest
.LP2PReceiver
andLP2PQuicTransportListener
. However, that does reflect their different way of working.One way to address these is to add shorthand helpers as existed in the original explainer, pseudo code example:
Preview | Diff