Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Floods Part 3: Adding Inundation Maps; COUNTRY=cambodia #1332

Open
wants to merge 24 commits into
base: feature/google-floods-forecast-chart/1317
Choose a base branch
from

Conversation

lowriech
Copy link
Collaborator

@lowriech lowriech commented Aug 22, 2024

api/app/googleflood.py Outdated Show resolved Hide resolved
@lowriech
Copy link
Collaborator Author

@gislawill this is updated to call gauges, rather than rely on a previous call passing its attributes

@gislawill gislawill force-pushed the feature/google-floods-inundation branch from d358674 to bb77ff7 Compare September 2, 2024 23:50
@gislawill gislawill changed the base branch from feature/google-floods/1317 to feature/google-floods-forecast-chart/1317 September 2, 2024 23:51
Copy link

github-actions bot commented Sep 2, 2024

Build succeeded and deployed at https://prism-1332.surge.sh
(hash 0338024 deployed at 2024-10-10T14:53:52)

@gislawill gislawill marked this pull request as ready for review October 7, 2024 02:57
@gislawill gislawill changed the title Adding Google Floods Inundation API Adding Google Floods Inundation Map Oct 7, 2024
@gislawill gislawill changed the title Adding Google Floods Inundation Map Adding Google Floods Inundation Map; COUNTRY=cambodia Oct 7, 2024
@gislawill
Copy link
Collaborator

Seeing kind of a weird bug while doing QA, the flood layer is loading in with various shades for the same data. It's very intermittent — changes with each page reload. I'm digging into figure it out. @ericboucher, have you see this in the past with any other layers?

Darkest (correct) Medium Light
Screenshot 2024-10-07 at 2 41 10 PM Screenshot 2024-10-07 at 2 38 18 PM Screenshot 2024-10-07 at 2 38 47 PM

@gislawill gislawill force-pushed the feature/google-floods-inundation branch from 5fe2435 to 03d6ac2 Compare October 7, 2024 20:00
@ericboucher
Copy link
Collaborator

@gislawill I have not seen this before. Could this be a bug linked to the opacity?

@gislawill
Copy link
Collaborator

@gislawill I have not seen this before. Could this be a bug linked to the opacity?

I don't believe so - the opacity is always coming through as .9 (tested it at 1 just to be sure too). I think it may have to do with layer order. The theory being that if it's rendered under 1 admin level its somewhat lighter, 2 admin layers and it's much lighter. The layer order in the canvas doesn't necessary match the layer order in jsx so I think I'll have to play around with "beforeId" prop to test it out

@wadhwamatic
Copy link
Member

@gislawill - I've not been able to access the flood inundation layer through the surge deployment, but it works locally. Here's the error I see on surge:
Screenshot 2024-10-10 at 13 46 55

Things look good locally. I've not seen the shading error you mentioned.

@gislawill
Copy link
Collaborator

gislawill commented Oct 11, 2024

@gislawill - I've not been able to access the flood inundation layer through the surge deployment, but it works locally.

Oh weird, it looks like this https request to the prism-api is getting redirected to a http request by cloudflare the prism-api. I'm not sure why that would be but I'll look into it

@gislawill gislawill changed the title Adding Google Floods Inundation Map; COUNTRY=cambodia Google Floods Part 2: Adding Inundation Maps; COUNTRY=cambodia Oct 24, 2024
@gislawill gislawill changed the title Google Floods Part 2: Adding Inundation Maps; COUNTRY=cambodia Google Floods Part 3: Adding Inundation Maps; COUNTRY=cambodia Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants