Adding Caller Id Features #12
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on deprecating the
sourceIdTimer
functionality in theVirtualChannel
class. The changes involve commenting out all references tosourceIdTimer
, effectively disabling its initialization, usage, and callback logic. Additionally, a minor update ensures theCallerId
field is reset during state updates. Below is a breakdown of the most important changes:Deprecation of
sourceIdTimer
functionality:sourceIdTimer
and its associated callback (sourceIdTimerCallback
) in theVirtualChannel
constructor to prevent it from being set up (rc2-dvm/VirtualChannel.cs
, rc2-dvm/VirtualChannel.csL189-R190).sourceIdTimerCallback
method by commenting out its implementation, removing the alternating display of the source ID and talkgroup name (rc2-dvm/VirtualChannel.cs
, rc2-dvm/VirtualChannel.csL289-R303).sourceIdTimer.Start()
andsourceIdTimer.Stop()
in theP25DataReceived
method andresetCall
method to stop triggering the timer (rc2-dvm/VirtualChannel.P25.cs
, [1] [2];rc2-dvm/VirtualChannel.cs
, [3].sourceIdTimer
declaration to indicate it is no longer in use (rc2-dvm/VirtualChannel.cs
, rc2-dvm/VirtualChannel.csL61-R61).State management improvement:
dvmRadio.Status.CallerId
to an empty string during state updates in theP25DataReceived
method, ensuring the caller ID is cleared when transitioning to an idle state (rc2-dvm/VirtualChannel.P25.cs
, rc2-dvm/VirtualChannel.P25.csL530-R534).