Skip to content

Conversation

djshadowxm82
Copy link

This pull request focuses on deprecating the sourceIdTimer functionality in the VirtualChannel class. The changes involve commenting out all references to sourceIdTimer, effectively disabling its initialization, usage, and callback logic. Additionally, a minor update ensures the CallerId field is reset during state updates. Below is a breakdown of the most important changes:

Deprecation of sourceIdTimer functionality:

  • Commented out the initialization of sourceIdTimer and its associated callback (sourceIdTimerCallback) in the VirtualChannel constructor to prevent it from being set up (rc2-dvm/VirtualChannel.cs, rc2-dvm/VirtualChannel.csL189-R190).
  • Disabled the sourceIdTimerCallback method by commenting out its implementation, removing the alternating display of the source ID and talkgroup name (rc2-dvm/VirtualChannel.cs, rc2-dvm/VirtualChannel.csL289-R303).
  • Commented out all calls to sourceIdTimer.Start() and sourceIdTimer.Stop() in the P25DataReceived method and resetCall method to stop triggering the timer (rc2-dvm/VirtualChannel.P25.cs, [1] [2]; rc2-dvm/VirtualChannel.cs, [3].
  • Commented out the sourceIdTimer declaration to indicate it is no longer in use (rc2-dvm/VirtualChannel.cs, rc2-dvm/VirtualChannel.csL61-R61).

State management improvement:

  • Added a line to reset dvmRadio.Status.CallerId to an empty string during state updates in the P25DataReceived method, ensuring the caller ID is cleared when transitioning to an idle state (rc2-dvm/VirtualChannel.P25.cs, rc2-dvm/VirtualChannel.P25.csL530-R534).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant