Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default waiting state to false to avoid SSR override #1816

Merged
merged 1 commit into from
Jan 14, 2018
Merged

Set default waiting state to false to avoid SSR override #1816

merged 1 commit into from
Jan 14, 2018

Conversation

luhagel
Copy link
Contributor

@luhagel luhagel commented Jan 12, 2018

Currently, the waiting state get's overwritten by the server version, leaving signIn buttons permanently disabled.

@luhagel luhagel mentioned this pull request Jan 12, 2018
Closed
@eric-burel
Copy link
Contributor

eric-burel commented Jan 13, 2018 •
edited
Loading

Hi,
Almost got it working, but how do can I confirm that I am loading the correct meteor package dir ? It seems that your PR isn't taken into account in my app, so either it does not work or I don't apply it. Are you sure setting this state to false is enough ? Can't the tracker run once and make waiting false again ?

Edit: seems that I still didn't manage to use a 2-repo install ^^ AdmitHub/meteor-buildpack-horse#188

@SachaG
Copy link
Contributor

SachaG commented Jan 14, 2018

I haven't had this issue myself but it seems like a reasonable fix. I'll merge it.

@SachaG SachaG merged commit edff18f into VulcanJS:devel Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luhagel @eric-burel @SachaG