review comments

VowpalWabbit · Feb 8, 2024 · ec2f546 · ec2f546
1 parent cb7fb61
commit ec2f546
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 15 deletions.
diff --git a/examples/rl_sim_cpp/azure_credentials.cc b/examples/rl_sim_cpp/azure_credentials.cc
@@ -59,6 +59,8 @@ int AzureCredentials::get_credentials(
     std::cout << "Unknown error while getting auth token";
     return error_code::external_error;
   }
+#  else
+#    error Requires C++14 or greater
 #  endif
   return error_code::success;
 }

diff --git a/rlclientlib/logger/http_transport_client.h b/rlclientlib/logger/http_transport_client.h
@@ -164,17 +164,6 @@ pplx::task<http_response> http_transport_client<TAuthorization>::http_request_ta
   utility::stl_container_adapter container(_post_data.get());
   const size_t container_size = container.size();
 
-  /*
-    std::string payload((char*)(container.begin()), container_size);
-    std::string body = "{Body\":\"";
-    body += payload;
-    body += "\"}";
-
-    std::cout << body << std::endl << std::endl;
-
-    const auto stream = concurrency::streams::bytestream::open_istream(body);
-    request.set_body(stream, body.size());
-  */
   const auto stream = concurrency::streams::bytestream::open_istream(container);
   request.set_body(stream, container_size);
 

diff --git a/rlclientlib/model_mgmt/restapi_data_transport_oauth.cc b/rlclientlib/model_mgmt/restapi_data_transport_oauth.cc
@@ -64,7 +64,7 @@ int restapi_data_transport_oauth::get_data_info(
 {
   // Get request URI and start the request.
   http_request request(_method_type);
-  RETURN_IF_FAIL(add_authentiction_header(request.headers(), status));
+  RETURN_IF_FAIL(add_authentication_header(request.headers(), status));
   // Build request URI and start the request.
   auto request_task = _httpcli->request(request).then(
       [&](http_response response)
@@ -111,7 +111,7 @@ int restapi_data_transport_oauth::get_data_info(
   }
 }
 
-int restapi_data_transport_oauth::add_authentiction_header(http_headers& header, api_status* status)
+int restapi_data_transport_oauth::add_authentication_header(http_headers& header, api_status* status)
 {
   if (_model_source != model_source::AZURE)
   {
@@ -132,7 +132,7 @@ int restapi_data_transport_oauth::get_data(model_data& ret, api_status* status)
   if (curr_last_modified == _last_modified && curr_datasz == _datasz) { return error_code::success; }
   _method_type = methods::GET;
   http_request request(_method_type);
-  RETURN_IF_FAIL(add_authentiction_header(request.headers(), status));
+  RETURN_IF_FAIL(add_authentication_header(request.headers(), status));
   // Build request URI and start the request.
   auto request_task =
       _httpcli

diff --git a/rlclientlib/model_mgmt/restapi_data_transport_oauth.h b/rlclientlib/model_mgmt/restapi_data_transport_oauth.h
@@ -30,7 +30,7 @@ class restapi_data_transport_oauth : public i_data_transport
 private:
   using time_t = std::chrono::time_point<std::chrono::system_clock>;
   int get_data_info(::utility::datetime& last_modified, ::utility::size64_t& sz, api_status* status);
-  int add_authentiction_header(http_headers& header, api_status* status);
+  int add_authentication_header(http_headers& header, api_status* status);
   std::unique_ptr<i_http_client> _httpcli;
   ::utility::datetime _last_modified;
   uint64_t _datasz;