more clang tidy fixes

VowpalWabbit · Feb 6, 2024 · 81ff98c · 81ff98c
1 parent 7c59f60
commit 81ff98c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rlclientlib/model_mgmt/restapi_data_transport_oauth.cc b/rlclientlib/model_mgmt/restapi_data_transport_oauth.cc
@@ -24,7 +24,7 @@ namespace model_management
 {
 restapi_data_transport_oauth::restapi_data_transport_oauth(
     i_http_client* httpcli, i_trace* trace, oauth_callback_t& callback, std::string scope)
-    : _httpcli(httpcli), _datasz{0}, _trace{trace}, _headerimpl(callback, std::move(scope))
+    : _httpcli(httpcli), _datasz{0}, _trace{trace}, _headerimpl(callback, scope)
 {
 }
 restapi_data_transport_oauth::restapi_data_transport_oauth(std::unique_ptr<i_http_client>&& httpcli,

diff --git a/rlclientlib/utility/api_header_token.h b/rlclientlib/utility/api_header_token.h
@@ -53,7 +53,7 @@ template <typename Resource>
 class api_header_token_callback
 {
 public:
-  api_header_token_callback(oauth_callback_t& token_cb, std::string scope)
+  api_header_token_callback(oauth_callback_t& token_cb, std::string& scope)
       : _token_callback(token_cb), _scopes{std::move(scope)}
   {
   }