feat(file-picker): support clearing files (VIV-1995) #1983
+77
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 354 +231
Lines 1562 7028 +5466
Branches 108 914 +806
===========================================
+ Hits 1562 7028 +5466
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YonatanKra
requested changes
Nov 7, 2024
Comment on lines
+53
to
+56
| /** | ||
| * @internal | ||
| */ | ||
| _dropzone?: Dropzone; |
There was a problem hiding this comment.
Why do we need to expose dropzone?
| @@ -73,6 +73,7 @@ describe('vwc-file-picker', () => { | |||
| unmountedElement.maxFileSize = 256; | |||
| unmountedElement.maxFiles = 1; | |||
| unmountedElement.accept = '.jpg'; | |||
| unmountedElement.removeAllFiles(); | |||
There was a problem hiding this comment.
Isn't removeAllFiles tested in its own it?
| @@ -111,6 +112,17 @@ describe('vwc-file-picker', () => { | |||
| addFiles([await generateFile('london.png', 1)]); | |||
| expect(element.value).toBe('C:\\fakepath\\london.png'); | |||
| }); | |||
|
|
|||
| it('should remove all files when setting value to an empty string', async function () { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.