Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): banner page in new format (VIV-2084) #1978

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rachelbt
Copy link
Contributor

@rachelbt rachelbt commented Nov 4, 2024

No description provided.

@rachelbt rachelbt marked this pull request as draft November 4, 2024 09:42
@rachelbt rachelbt marked this pull request as ready for review November 4, 2024 10:51
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (c40a6cc).
Report is 1141 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1978     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       355    +232     
  Lines         1562      7155   +5593     
  Branches       108       942    +834     
===========================================
+ Hits          1562      7155   +5593     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaylorJ76 TaylorJ76 changed the title chore(docs): badge page in new format (VIV-2084) chore(docs): banner page in new format (VIV-2084) Nov 5, 2024
Copy link
Contributor

@TaylorJ76 TaylorJ76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small changes

libs/components/src/lib/banner/README.md Show resolved Hide resolved
libs/components/src/lib/banner/GUIDELINES.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants