feat(file-picker): add single file mode (VIV-1988) #1974
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 354 +231
Lines 1562 7025 +5463
Branches 108 912 +804
===========================================
+ Hits 1562 7025 +5463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
None of these examples work unless they are wrapped in a form (like in the Form use case). Can we wrap all then examples in a form so that users can see how it functions?
Also, can we change the Max Files example to be more than 1, and put a note to say to use the single-file attribute if you only want to upload one file?
| @@ -114,6 +114,19 @@ Use the `size` attribute to set the file picker's to one of the predefined block | |||
| </vwc-file-picker> | |||
| ``` | |||
|
|
|||
| ### Single File | |||
There was a problem hiding this comment.
Can we move this example up the page a bit to be above the Max File Size example?
There was a problem hiding this comment.
I moved it just below label.
Regarding the form change - can you please elaborate what doesn't work outside a form?
We never put form elements inside a form in the examples, because we'd like people to be able to just copy and paste the code (K.I.S.).
There was a problem hiding this comment.
Sorry, my bad. It does work. It's just that the file list gets cut off in the examples.
Can we give the examples more height so that at least one selected file will appear inside the viewing area?
No description provided.