Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): card page new format (VIV-2086) #1972

Merged
merged 12 commits into from
Nov 4, 2024
Merged

chore(docs): card page new format (VIV-2086) #1972

merged 12 commits into from
Nov 4, 2024

Conversation

rachelbt
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (e694634).
Report is 1138 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1972     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       354    +231     
  Lines         1562      6992   +5430     
  Branches       108       905    +797     
===========================================
+ Hits          1562      6992   +5430     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TaylorJ76 TaylorJ76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the headings are in title case

Online tool

| Name | Type | Description |
| -------------- | ----------------------------------------- | ----------------------------- |
| **appearance** | `elevated` (default), `outlined`, `ghost` | Sets the element's appearance |
| **elevation** | `2`, `4` (default), `8`, `12`, `16`, `24` | Sets the element's elevation |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about headline, subtitle and text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same as button and text-field - where the label and other text prop not in the list
https://vivid.deno.dev/components/button/code/#properties
https://vivid.deno.dev/components/text-field/code/#properties

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go back over those then. Thanks for pointing that out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

libs/components/src/lib/card/README.md Show resolved Hide resolved
libs/components/src/lib/card/USE-CASES.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/VARIATIONS.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/VARIATIONS.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/README.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/USE-CASES.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/GUIDELINES.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/GUIDELINES.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/GUIDELINES.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/GUIDELINES.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/GUIDELINES.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/USE-CASES.md Outdated Show resolved Hide resolved
libs/components/src/lib/card/USE-CASES.md Outdated Show resolved Hide resolved
@rachelbt rachelbt merged commit 6de922b into main Nov 4, 2024
15 checks passed
@rachelbt rachelbt deleted the VIV-2086-card branch November 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants