-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): card page new format (VIV-2086) #1972
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 354 +231
Lines 1562 6992 +5430
Branches 108 905 +797
===========================================
+ Hits 1562 6992 +5430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the headings are in title case
| Name | Type | Description | | ||
| -------------- | ----------------------------------------- | ----------------------------- | | ||
| **appearance** | `elevated` (default), `outlined`, `ghost` | Sets the element's appearance | | ||
| **elevation** | `2`, `4` (default), `8`, `12`, `16`, `24` | Sets the element's elevation | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about headline
, subtitle
and text
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the same as button and text-field - where the label and other text prop not in the list
https://vivid.deno.dev/components/button/code/#properties
https://vivid.deno.dev/components/text-field/code/#properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go back over those then. Thanks for pointing that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Co-authored-by: James Taylor <[email protected]>
No description provided.