feat(checkbox): aria-checked now properly conveys and controls checkbox state (VIV-1598) #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 21, 2024 12:35
…ox state feat(checkbox): aria-checked now controls indeterminate state
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 353 +230
Lines 1562 6974 +5412
Branches 108 902 +794
===========================================
+ Hits 1562 6974 +5412
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rachelbt
reviewed
Oct 21, 2024
Co-authored-by: Rachel Bratt Tannenbaum <[email protected]>
…-and-handle-indeterminate-state
rachelbt
approved these changes
Oct 22, 2024
…-and-handle-indeterminate-state
…-and-handle-indeterminate-state
TaylorJ76
deleted the
VIV-1598-automatically-populate-aria-checked-and-handle-indeterminate-state
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(checkbox): aria-checked now controls indeterminate state (VIV-1598)
The relevant aria-checked state is the one on the element with
role="checkbox"- in our case the base element.FastFoundation also adds
aria-checkedon the host which is currently redundent as it has no role (we should change the basedivtotemplatewhen we port away fromFoundationCheckbox.