-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default email template with extended base #268
Open
Vardane
wants to merge
25
commits into
Volontaria:develop
Choose a base branch
from
Vardane:enhancement-default_email_template_with_extended_base
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added default email template with extended base #268
Vardane
wants to merge
25
commits into
Volontaria:develop
from
Vardane:enhancement-default_email_template_with_extended_base
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il_template fix some tests
Vardane
changed the title
Enhancement default email template with extended base
Added default email template with extended base
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed ?
Incorporated default template emails to be used when a participation gets created or cancelled.
How did you change it ?
Added .html and .txt template files; edited functions governing email creation on participation creation or deletion; added tests.
Is there a special consideration?
.html files extend a base.html file, which may conflict with SendinBlue behaviour. So consider merging enhancement-default_email_template branch instead of the branch in this current pull request.
Verification :
CONTRIBUTING.md
CONTRIBUTING.md