Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update context parameters migration #433

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Update context parameters migration #433

merged 6 commits into from
Jul 8, 2024
+1,062 −944

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Jul 4, 2024 •
edited
Loading

Resolves #432
Resolves #431

@asimonok asimonok requested a review from mikhail-vl July 4, 2024 07:32
@asimonok asimonok self-assigned this Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.98%. Comparing base (eb8de59) to head (e9a5ede).

Files Patch % Lines
src/migration.ts 95.12% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   99.10%   98.98%   -0.12%     
==========================================
  Files          76       76              
  Lines        1668     1672       +4     
  Branches      492      493       +1     
==========================================
+ Hits         1653     1655       +2     
- Misses         13       15       +2     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 4, 2024
@mikhail-vl mikhail-vl added this to the Version 4.1.0 milestone Jul 4, 2024
@mikhail-vl mikhail-vl changed the title Add checking if parameter without context. prefix Update context parameters migration Jul 8, 2024
mikhail-vl
mikhail-vl approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 9177531 into main Jul 8, 2024
5 of 7 checks passed
@mikhail-vl mikhail-vl deleted the feat/fix-non-context-parameters-migration branch July 8, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@asimonok asimonok

Labels
enhancement New feature or request
Milestone
Version 4.1.0
2 participants
@asimonok @mikhail-vl