Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pagination options to separate category #87

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Move pagination options to separate category #87

merged 6 commits into from
Oct 1, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #85

@vitPinchuk vitPinchuk self-assigned this Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (1a33e34) to head (821c7dd).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   99.75%   99.79%   +0.04%     
==========================================
  Files         153      158       +5     
  Lines        2409     2436      +27     
  Branches      542      546       +4     
==========================================
+ Hits         2403     2431      +28     
+ Misses          6        5       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Sep 30, 2024
@mikhail-vl mikhail-vl added this to the Table 1.4.0 milestone Sep 30, 2024
@mikhail-vl mikhail-vl changed the title Move pagination options to separate category Update pagination options moving to separate category Sep 30, 2024
@mikhail-vl mikhail-vl changed the title Update pagination options moving to separate category Move pagination options to separate category Sep 30, 2024
asimonok
asimonok approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 7473b45 into main Oct 1, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/pagination-options-to-separate-category branch October 1, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Table 1.4.0
Development

Successfully merging this pull request may close these issues.

Move pagination options to separate category similar to editable data
4 participants
@vitPinchuk @codecov-commenter @asimonok @mikhail-vl