Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rows heights when group collapse #159

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Update rows heights when group collapse #159

merged 2 commits into from
Nov 14, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #149

@vitPinchuk vitPinchuk self-assigned this Nov 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (b8fa21d) to head (be315e5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         162      162           
  Lines        2545     2546    +1     
  Branches      573      573           
=======================================
+ Hits         2539     2540    +1     
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 14, 2024
@mikhail-vl mikhail-vl added this to the Table 1.7.0 milestone Nov 14, 2024
asimonok
asimonok approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl changed the title Refresh rows heights Update rows heights when grouping Nov 14, 2024
@mikhail-vl mikhail-vl changed the title Update rows heights when grouping Update rows heights when group collapse Nov 14, 2024
mikhail-vl
mikhail-vl approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 780eb68 into main Nov 14, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/dynamic-height branch November 14, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Table 1.7.0
Development

Successfully merging this pull request may close these issues.

Refresh rows heights for rows with multi line columns
4 participants
@vitPinchuk @codecov-commenter @asimonok @mikhail-vl