Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fields in items getting mixed up #76

Merged
merged 15 commits into from
Jun 7, 2024
Merged

Update fields in items getting mixed up #76

merged 15 commits into from
Jun 7, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #74

@vitPinchuk vitPinchuk self-assigned this May 23, 2024
@mikhail-vl mikhail-vl added this to the Version 4.1.0 milestone May 23, 2024
@mikhail-vl mikhail-vl added the enhancement New feature or request label May 23, 2024
asimonok
asimonok requested changes May 24, 2024
View reviewed changes
src/utils.test.ts Outdated Show resolved Hide resolved
asimonok
asimonok approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl requested changes May 26, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some records in Volkov Labs YouTube channel and Grafana RSS feed has empty spaces and displayed incorrectly:

Screenshot 2024-05-26 at 1 24 22 PM

@vitPinchuk
Copy link
Contributor Author

@mikhail-vl ready for review

asimonok
asimonok approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl requested a review from asimonok June 5, 2024 04:15
asimonok
asimonok approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl changed the title Fields in items getting mixed up Update fields in items getting mixed up Jun 7, 2024
mikhail-vl
mikhail-vl approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 4fcb214 into main Jun 7, 2024
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/data-source-mixed-up branch June 7, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 4.1.0
Development

Successfully merging this pull request may close these issues.

tag in items getting scrambled
3 participants
@vitPinchuk @asimonok @mikhail-vl