Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tests coverage #47

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Increase tests coverage #47

merged 8 commits into from
Jul 6, 2023

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Jul 6, 2023

Increase tests coverage.
Resolves #45.

@asimonok asimonok changed the title Add tests for FieldsEditor Increase tests coverage Jul 6, 2023
@asimonok asimonok self-assigned this Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +32.53 🎉

Comparison is base (936c8d9) 66.78% compared to head (ee80857) 99.32%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #47       +/-   ##
===========================================
+ Coverage   66.78%   99.32%   +32.53%     
===========================================
  Files          30       30               
  Lines         286      295        +9     
  Branches       35       36        +1     
===========================================
+ Hits          191      293      +102     
+ Misses         89        0       -89     
+ Partials        6        2        -4     
Impacted Files Coverage Δ
src/constants/tests.ts 100.00% <ø> (ø)
src/components/FieldsEditor/FieldsEditor.tsx 100.00% <100.00%> (+66.66%) ⬆️
src/components/ValueInput/ValueInput.tsx 97.22% <100.00%> (+64.78%) ⬆️
src/components/ValuesEditor/ValuesEditor.tsx 100.00% <100.00%> (+64.86%) ⬆️
src/module.ts 100.00% <100.00%> (ø)
src/utils/frame.ts 100.00% <100.00%> (+41.17%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 6, 2023
@mikhail-vl mikhail-vl added this to the Version 3.1.0 milestone Jul 6, 2023
@mikhail-vl mikhail-vl self-requested a review July 6, 2023 12:13
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 8e80fd9 into main Jul 6, 2023
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/increase-tests-coverage branch July 6, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Test Coverage
2 participants