Add additional website logos. #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calamitish
commented
Apr 24, 2025
Calamitish
commented
- Adds AH-Software.
- Adds A.I. voice.
- Fix issue with alicebooks.png
- Add BandLab.
- Add Dreamtonics.
- Add Genius.
- Add Github.
- Add Marshmallow QA.
- Add Musixmatch.
- Fix poppro.png
- Add Project SEKAI wiki.
- Add Reddit.
- Add VOICEVOX.
- Add Voisona.
- Adds AH-Software. - Adds A.I. voice. - Fix issue with alicebooks.png - Add BandLab. - Add Dreamtonics. - Add Genius. - Add Github. - Add Marshmallow QA. - Add Musixmatch. - Fix poppro.png - Add Project SEKAI wiki. - Add Reddit. - Add VOICEVOX. - Add Voisona.
Calamitish
added a commit
to Calamitish/vocadb
that referenced
this pull request
Apr 24, 2025
# ExtLinks.css: - Re-order ExtLinks.css by logo image name alphabetically. - - With exception for those those that have a logo in a different repository, move those to the top. - Clean up usage of background-image vs background. - Fix icon matching with links that only matched to http:// to also work with https:// - Add icon matching with links that did have icons, but were not being used. - Add additional icon matching with new icons (see: VocaDB/ExtIcons#7) - Icon matching via ^ match or * match has been left mostly the same, could still be a discussion point. - Clean up styling. # WebLinkMatcher.ts - Add additonal Weblink matchers relating to VocaDB/ExtIcons#7
|
alicebooks and poppro icons conflict with PR #8 |
Calamitish
added a commit
to Calamitish/vocadb
that referenced
this pull request
Apr 26, 2025
See: VocaDB/ExtIcons#7 - ah-soft - ai-voice - bandlab - dreamtonics - genius - github - marshmallow-qa - musixmatch - project sekai fandom wiki - reddit - voicevox - voisona
FinnRG
pushed a commit
to VocaDB/vocadb
that referenced
this pull request
Apr 27, 2025
* Refactor WebLinkMatcher.ts and add additional. # ExtLinks.css: - Re-order ExtLinks.css by logo image name alphabetically. - - With exception for those those that have a logo in a different repository, move those to the top. - Clean up usage of background-image vs background. - Fix icon matching with links that only matched to http:// to also work with https:// - Add icon matching with links that did have icons, but were not being used. - Add additional icon matching with new icons (see: VocaDB/ExtIcons#7) - Icon matching via ^ match or * match has been left mostly the same, could still be a discussion point. - Clean up styling. # WebLinkMatcher.ts - Add additonal Weblink matchers relating to VocaDB/ExtIcons#7 * Revert "Refactor WebLinkMatcher.ts and add additional." This reverts commit 4efdaa5. * Add additional linkmatchers. * Replace all double with single quotes. * Add trailing slash to all URLs. * Replace all instances of background: with background-image: * Unify http and https checks. Some matchers would only match with http or https URLs. * Make bracket usage consistent. * Remove or combine duplicate entries. * Split Dwango and Animelo to use correct image. * Remove dead comment. * Move matchers with images not in ExtIcons to the top and add a comment where neccesary. * Sort all icon matchers alphabetically by png filename. * Adjust fasic and thbwiki to match filename. * Add icon matchers that have images but no matchers. - bsky - dojin-music * Add additional icon matchers. See: VocaDB/ExtIcons#7 - ah-soft - ai-voice - bandlab - dreamtonics - genius - github - marshmallow-qa - musixmatch - project sekai fandom wiki - reddit - voicevox - voisona * Fix missed unified http/https check. * Add back trailing slashes. * Process feedback. - Re-add accidentally removed link matchers. - Fix brace. * Remove regex from link matchers. * Fix malformed link matchers. * Set archive matcher last so it always takes precedence.
|
@Calamitish I've merged #8. You can now go ahead with resolving the merge conflict here. |
…e-logos # Conflicts: # poppro.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.