Return 404 for collection-items request if collection doesn't exist

Rather than failing with a 500
VivienDelmon · Jan 16, 2021 · 324f9f5 · 324f9f5
1 parent fdfb097
commit 324f9f5
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/controllers/TagsController.php b/controllers/TagsController.php
@@ -94,6 +94,9 @@ public function tags() {
 					$empty = false;
 					if ($this->scopeObject == 'collection-items') {
 						$collection = Zotero_Collections::getByLibraryAndKey($this->objectLibraryID, $this->scopeObjectKey);
+						if (!$collection) {
+							$this->e404();
+						}
 						$itemIDs = $collection->getItems(true);
 						$itemParams['itemIDs'] = $itemIDs;
 						if (!$itemIDs) {