Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(skyline): Modified error message for Skyline outlining that MSstats only analyzes MS1 or MS2 but not both #89

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Mar 15, 2024

Motivation and Context

In this Google group post, the user got the below error message when they included both MS1 (precursor) and MS2 (fragment) ions in the FragmentIon column for an SRM experiment.

'Error in .checkDDA(input): **Please check precursors information. If your experiment is DIA, please remove the precursors. If your experiment is DDA, please check the precursor information.'

We should be more clear that MSstats does not analyze both MS1 and MS2 simultaneously. We also need to point them to the FragmentIon column to make the fix and let them know what to do for the SRM scenario.

Changes

Please provide a detailed bullet point list of your changes.

  • Modified error message within the .checkDDA function that outlines that MSstats does not analyze both MS1 and MS2 simultaneously. I also point the user to the FragmentIon column to make the fix and outlined that precursors should be removed for SRM.
  • Minor: Update PR template & dry run build workflows

Testing

Tested on the input file from the user and the error message is updated as expected.

Checklist Before Requesting a Review

  • I have read this repository's contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@mstaniak
Copy link
Contributor

Thanks!

@tonywu1999 tonywu1999 merged commit f5a5f6c into devel Mar 19, 2024
1 check passed
@tonywu1999 tonywu1999 deleted the error-messages branch March 19, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants