Use cypress run events to automatically signal the test run to VRT #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my opinion it would make sense if the plugin automatically starts and stops when the cypress run starts and stops. My suggestion would be to use the cypress events to do it. Makes the usage much simpler and also prevents the VRT plugin turn on / off the progress indicator for every spec. Whats your opinion on this?
pashidlos
requested changes
Sep 18, 2022
There was a problem hiding this comment.
@tobmaster thanks for contribution!
looks good to me!
I would make it as new major release
also remove start/stop methods form interface as they no longer needed for users
and update doc
|
Yeah I can do it. |
|
Still have to test it though |
|
@tobmaster Hi there! Would you have time to update this PR? |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion it would make sense if the plugin automatically starts and stops when the cypress run starts and stops.
My suggestion would be to use the cypress events to do it. Makes the usage much simpler and also prevents the VRT plugin turn on / off the progress indicator for every spec.
Whats your opinion on this?