Skip to content

test: add test getChartSpecWithContext with lineChart #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RubMaker
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

#215

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

add unit test for getChartSpecWithContext() when chartType is linechart

📝 Changelog

Language Changelog
🇺🇸 English add unit test for getChartSpecWithContext() when chartType is linechart
🇨🇳 Chinese 为getChartSpecWithContext()添加单测(图标类型为折线图)

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@github-actions github-actions bot added the vmind label May 22, 2025
@666haiwen
Copy link
Contributor

Besides this test case, you can also add a test case of line chart with color field.

}
]
};
const { chartType, spec } = getChartSpecWithContext(context);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个测试太简单了,起不到本质上的意义,不能覆盖各种大模型产出线图的场景

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants