Block calls with failed verification #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papjul
commented
Feb 8, 2025
| if (callDetails.getCallerNumberVerificationStatus() == | ||
| Connection.VERIFICATION_STATUS_NOT_VERIFIED | ||
| ) { | ||
| LOG.trace("onScreenCall() not verified"); |
There was a problem hiding this comment.
Since you live in France like me, mobile phone numbers always return NOT_VERIFIED.
So, to test the feature, you could add isFailedVerification = true; here and have someone call you (remember to remove it afterwards).
|
@Vinetos Hi, do you need help with the two PR pending? If you don't have time to review them at the moment, would it be possible to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21
Requires Android >= 11 and advanced blocking mode.
Successfully show a blocked call notification when the call fails verification.
However, this won't show in the call logs, because as far as I can see, Android doesn't store this information in call logs.
If we want to show it, we would need to duplicate all calls in a local database table, and have some way to make received calls match with Android system logs. Not a trivial work.
At least the feature is working as intended, so I believe this can be a good first step.