Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use click v7 #96

Closed
wants to merge 1 commit into from
Closed

Use click v7 #96

wants to merge 1 commit into from

Conversation

rhysd
Copy link

@rhysd rhysd commented May 14, 2021

Fixes #95

@blueyed
Copy link
Member

blueyed commented May 14, 2021

Thanks for giving it a try.
I think/guess that we should/could support the newer version though.
I've started with that in #97.

The CircleCI integration apparently was broken here, closing/re-opening to re-trigger it for now here.

@blueyed blueyed closed this May 14, 2021
@blueyed blueyed reopened this May 14, 2021
@rhysd
Copy link
Author

rhysd commented May 15, 2021 •
edited
Loading

I think/guess that we should/could support the newer version though.

Yes, that's definitely better. I thought this was just a workaround meanwhile.

I've started with that in #97.

Thank you for working on that. Then I think this PR can be closed.

@rhysd rhysd closed this May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install error with click v8.0.0
2 participants
@rhysd @blueyed