Skip to content

fix: use kuali data to generate subjects #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use kuali data to generate subjects #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions functions/src/subjects/Subject.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,30 @@
import { UVicCourseScraper } from '@vikelabs/uvic-course-scraper/dist';
import {
KualiSubject,
UVicCourseScraper,
} from '@vikelabs/uvic-course-scraper/dist';
import { Term } from '../constants';
import { Subject } from './Subject.model';

export class SubjectsService {
public static async getSubjects(term: Term): Promise<Subject[]> {
const subjects = await UVicCourseScraper.getSubjects(term);
return subjects.map(({ subject, title }) => ({
const subjects: KualiSubject[] = (
await UVicCourseScraper.getCourses(term)
).response.map((course) => {
return {
subject: course.subjectCode.name,
title: course.subjectCode.description,
};
});

// remove duplicates based on two keys

const m = new Map<string, KualiSubject>();
subjects.forEach((subject) => {
m.set(`${subject.subject}-${subject.title}`, subject);
});

// map to array
return Array.from(m.values()).map(({ subject, title }) => ({
subject,
// removes the subject within the title
title: title.replace(`(${subject})`, '').trim(),
Expand Down