Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP][14.0] viin_brand_*: update link to Viindoo #99

Merged
merged 1 commit into from
May 28, 2022
Merged

[IMP][14.0] viin_brand_*: update link to Viindoo #99

merged 1 commit into from
May 28, 2022

Conversation

Ngquang
Copy link

@Ngquang Ngquang commented May 11, 2022 •
edited
Loading

References to this task:

https://viindoo.com/web#cids=1&id=15403&menu_id=&model=project.task

  • Update link website in apriori
  • Change template show_website_info to link to Viindoo

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels May 11, 2022
@Ngquang Ngquang changed the title [IMP][14.0] viin_brand: update apriori [IMP][14.0] viin_brand_*: update apriori May 11, 2022
@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script 🚀 Queue PR/Commit is added in build queue and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels May 11, 2022
@Ngquang Ngquang changed the title [IMP][14.0] viin_brand_*: update apriori [IMP][14.0] viin_brand_*: update link to Viindoo May 11, 2022
@viinbot viinbot added 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Building PR/Commit is start building all step in script labels May 11, 2022
@Ngquang Ngquang requested a review from royle-vietnam May 12, 2022 02:27
royle-vietnam
royle-vietnam reviewed May 12, 2022
View reviewed changes
viin_brand_website/views/website_templates.xml Outdated
</xpath>

<xpath expr="//a[@t-attf-href='https://www.odoo.com/page/accounting/#{app.name}']" position="attributes">
<attribute name="t-attf-href">https://viindoo.com/apps/app/14.0/#{app.name}</attribute>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ngquang App store của mình đâu có link này đâu? như thế sẽ bị 404 à chú?

Copy link
Author

@Ngquang Ngquang May 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em thấy như https://viindoo.com/apps/app/14.0/l10n_vn_c200 cho TT200 vẫn được mà anh nhỉ. Một số app l10n của nước ngoài không có trên app store thì chắc mới bị 404 anh ạ. @royleviindoo

@viinbot viinbot added 🚩 Done PR/Commit is finished manually test and closed instance and removed 🚀 Running PR/Commit is done for everything and ready for manually test labels May 18, 2022
@leotranviindoo
Copy link

PR này sao rồi các chú? @Ngquang @royleviindoo

@Ngquang
Copy link
Author

Ngquang commented May 24, 2022 •
edited
Loading

@leotranviindoo Em đang vướng phần dẫn link về app store cho các app l10n ạ.
Nên em tách PR này ra để merge phần ở apriori trước vì đã có link của mkt.
cc @royleviindoo

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script and removed 🚩 Done PR/Commit is finished manually test and closed instance 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels May 24, 2022
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script 🚀 Queue PR/Commit is added in build queue labels May 24, 2022
@Ngquang Ngquang requested a review from royle-vietnam May 25, 2022 01:13
@davidtranhp davidtranhp merged commit 282221d into Viindoo:14.0 May 28, 2022
@Ngquang Ngquang deleted the v14_imp_viin_brand branch June 4, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royle-vietnam royle-vietnam Awaiting requested review from royle-vietnam

Assignees
No one assigned
Labels
🚀 Running PR/Commit is done for everything and ready for manually test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ngquang @leotranviindoo @royle-vietnam @davidtranhp @viinbot